New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CRMFPopClient on FIPS environment #4620

Merged

fmarco76 merged 1 commit into dogtagpki:master from fmarco76:CRMFPopFix

Nov 27, 2023

Member

fmarco76 commented Nov 27, 2023

When FIPS is enabled RSA key generation cannot have both temporary and sensitive to false.

Since temporary is defined from a command option the sensitive is set to null so the default for the environment will be used (true if FIPS is enabled and false if FIPS is disabled).

Fix BZ Bug 2250716


          Fix CRMFPopClient on FIPS environment

875e5c8

When FIPS is enabled RSA key generation cannot have both temporary and
sensitive to false.

Since temporary is defined from a command option the sensitive is set to
null so the default for the environment will be used (true if FIPS is
enabled and false if FIPS is disabled).

Fix BZ Bug 2250716

fmarco76 requested a review from edewata

November 27, 2023 11:09

sonarqubecloud bot commented Nov 27, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

edewata approved these changes

View reviewed changes

Contributor

edewata left a comment

I'm not an expert, but it looks good to me. Feel free to merge if you're pretty sure about this change, or check with @ladycfu or @jmagne.

Member Author

fmarco76 commented Nov 27, 2023

Thanks @edewata. The fix is similar to #4604 and this temporary/sensitive has been discussed in other places. I am merging for now

fmarco76 merged commit 0753e8d into dogtagpki:master

129 of 132 checks passed

fmarco76 deleted the CRMFPopFix branch

November 27, 2023 14:33

Contributor

ladycfu commented Nov 29, 2023

HI @fmarco76 sorry for the late reply. If this is tested to work with both HSMs that we claim to support then it should be fine. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet